netdev - Re: [PATCH net-next 10/10] ethtool: netlink: always pass genl_info to .prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230810184003.id4ouegp3kp6ciki@skbuf>
Date: Thu, 10 Aug 2023 21:40:03 +0300
From: Vladimir Oltean <vladimir.oltean@....com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, jiri@...nulli.us, johannes@...solutions.net,
	gal@...dia.com, tariqt@...dia.com, lucien.xin@...il.com,
	f.fainelli@...il.com, andrew@...n.ch, simon.horman@...igine.com,
	linux@...pel-privat.de, mkubecek@...e.cz
Subject: Re: [PATCH net-next 10/10] ethtool: netlink: always pass genl_info
 to .prepare_data

On Wed, Aug 09, 2023 at 11:26:48AM -0700, Jakub Kicinski wrote:
> We had a number of bugs in the past because developers forgot
> to fully test dumps, which pass NULL as info to .prepare_data.
> .prepare_data implementations would try to access info->extack
> leading to a null-deref.
> 
> Now that dumps and notifications can access struct genl_info
> we can pass it in, and remove the info null checks.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: gal@...dia.com
> CC: tariqt@...dia.com
> CC: lucien.xin@...il.com
> CC: f.fainelli@...il.com
> CC: andrew@...n.ch
> CC: vladimir.oltean@....com
> CC: simon.horman@...igine.com
> CC: linux@...pel-privat.de
> CC: mkubecek@...e.cz
> CC: johannes@...solutions.net
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
Tested-by: Vladimir Oltean <vladimir.oltean@....com> # pause

with:

$ ethtool -I --show-pause eno3 --src pmac
netlink error: ethtool_nl: Device does not support MAC merge layer
netlink error: Operation not supported