lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230811100613.o77ei6updvbndkjm@skbuf> Date: Fri, 11 Aug 2023 13:06:13 +0300 From: Vladimir Oltean <olteanv@...il.com> To: alexis.lothore@...tlin.com Cc: Clément Leger <clement@...ment-leger.fr>, Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Miquel Raynal <miquel.raynal@...tlin.com>, Milan Stevanovic <milan.stevanovic@...com>, Jimmy Lalande <jimmy.lalande@...com>, Pascal Eberhard <pascal.eberhard@...com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com> Subject: Re: [PATCH net-next v5 3/3] net: dsa: rzn1-a5psw: add vlan support On Thu, Aug 10, 2023 at 11:36:51AM +0200, alexis.lothore@...tlin.com wrote: > +static int a5psw_port_vlan_add(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_vlan *vlan, > + struct netlink_ext_ack *extack) > +{ > + dev_dbg(a5psw->dev, "Add VLAN %d on port %d, %s, %s\n", > + vid, port, tagged ? "tagged" : "untagged", > + pvid ? "PVID" : "no PVID"); > +} > + > +static int a5psw_port_vlan_del(struct dsa_switch *ds, int port, > + const struct switchdev_obj_port_vlan *vlan) > +{ > + dev_dbg(a5psw->dev, "Removing VLAN %d on port %d\n", vid, port); > +} These are unnecessary, we have trace points for VLANs in net/dsa/trace.h.
Powered by blists - more mailing lists