netdev - Re: [RFC PATCH net-next v2 1/2] net: veth: Page pool creation error handling for existing pools only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKhg4t+k62kNVMwdPo36bAK8eSc1MJrxsOQgMMMJ_TvKbLc+gQ@mail.gmail.com>
Date: Fri, 11 Aug 2023 19:56:34 +0800
From: Liang Chen <liangchen.linux@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, linyunsheng@...wei.com, hawk@...nel.org, 
	ilias.apalodimas@...aro.org, daniel@...earbox.net, ast@...nel.org, 
	netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-next v2 1/2] net: veth: Page pool creation error
 handling for existing pools only

On Tue, Aug 1, 2023 at 8:18 PM Simon Horman <horms@...nel.org> wrote:
>
> On Tue, Aug 01, 2023 at 02:19:31PM +0800, Liang Chen wrote:
> > The failure handling procedure destroys page pools for all queues,
> > including those that haven't had their page pool created yet. this patch
> > introduces necessary adjustments to prevent potential risks and
> > inconsistency with the error handling behavior.
> >
> > Signed-off-by: Liang Chen <liangchen.linux@...il.com>
>
> I wonder if this should this have a fixes tag and be targeted at 'net' as a
> bugfix?

It doesn't trigger a real bug at the moment as page_pool_destroy
handles NULL argument. So may not be suitable for a fix tag.

Thanks,
Liang