netdev - Re: [PATCH net-next 0/5] net: Use pci_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a703b919-65db-1500-6e65-5e9acb5f00cf@intel.com>
Date: Fri, 11 Aug 2023 14:18:16 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Zheng Zengkai <zhengzengkai@...wei.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<mark.einon@...il.com>, <siva.kallam@...adcom.com>, <prashant@...adcom.com>,
	<mchan@...adcom.com>, <steve.glendinning@...well.net>, <mw@...ihalf.com>,
	<jiawenwu@...stnetic.com>, <mengyuanlou@...-swift.com>
CC: <netdev@...r.kernel.org>, <wangxiongfeng2@...wei.com>
Subject: Re: [PATCH net-next 0/5] net: Use pci_dev_id() to simplify the code

On 8/11/23 13:06, Zheng Zengkai wrote:
> PCI core API pci_dev_id() can be used to get the BDF number for a pci
> device. Use the API to simplify the code.
> 
> Zheng Zengkai (5):
>    et131x: Use pci_dev_id() to simplify the code
>    tg3: Use pci_dev_id() to simplify the code
>    net: smsc: Use pci_dev_id() to simplify the code
>    net: tc35815: Use pci_dev_id() to simplify the code
>    net: ngbe: use pci_dev_id() to simplify the code
> 
>   drivers/net/ethernet/agere/et131x.c           | 3 +--
>   drivers/net/ethernet/broadcom/tg3.c           | 3 +--
>   drivers/net/ethernet/smsc/smsc9420.c          | 3 +--
>   drivers/net/ethernet/toshiba/tc35815.c        | 3 +--
>   drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c | 3 +--
>   5 files changed, 5 insertions(+), 10 deletions(-)
> 

code looks fine,
I wonder if it would be better to have just one patch here?