lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <9727375d-8d89-489b-bd3f-4f18930ff42c@lunn.ch> Date: Fri, 11 Aug 2023 15:13:38 +0200 From: Andrew Lunn <andrew@...n.ch> To: Daniel Golle <daniel@...rotopia.org> Cc: Qingfang Deng <dqfext@...il.com>, SkyLake Huang <SkyLake.Huang@...iatek.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH net-next] net: phy: mediatek-ge-soc: support PHY LEDs > > +#define MTK_PHY_LED_STATE_FORCE_ON BIT(0) > +#define MTK_PHY_LED_STATE_FORCE_BLINK BIT(1) > +#define MTK_PHY_LED_STATE_NETDEV BIT(2) > +struct mtk_socphy_priv { > + unsigned long led_state; > +}; Hi Daniel A blank line between the #defines and the struct would be nice. > + > +struct mtk_socphy_shared { > + u32 boottrap; > + struct mtk_socphy_priv priv[4]; > +}; > + > static int mtk_socphy_read_page(struct phy_device *phydev) > { > return __phy_read(phydev, MTK_EXT_PAGE_ACCESS); > @@ -1071,6 +1112,370 @@ static int mt798x_phy_config_init(struct phy_device *phydev) > return mt798x_phy_calibration(phydev); > } > > +static int mt798x_phy_hw_led_on_set(struct phy_device *phydev, u8 index, > + bool on) > +{ > + struct mtk_socphy_priv *priv = phydev->priv; > + u32 mask = MTK_PHY_LED_STATE_FORCE_ON << (index ? 16 : 0); > + bool changed; Reverse christmass tree please. Otherwise, this looks good. Andrew
Powered by blists - more mailing lists