netdev - Re: [PATCH 2/6] dt-bindings: imx-thermal: Add #thermal-sensor-cells property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <169176235704.3319932.12605780111430379869.robh@kernel.org>
Date: Fri, 11 Aug 2023 08:00:55 -0600
From: Rob Herring <robh@...nel.org>
To: Alexander Stein <alexander.stein@...tq-group.com>
Cc: Daniel Vetter <daniel@...ll.ch>, dri-devel@...ts.freedesktop.org, "Rafael J . Wysocki" <rafael@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Amit Kucheria <amitk@...nel.org>, linux-arm-kernel@...ts.infradead.org, Pengutronix Kernel Team <kernel@...gutronix.de>, "David S . Miller" <davem@...emloft.net>, Thomas Gleixner <tglx@...utronix.de>, linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>, Philipp Zabel <p.zabel@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>, David Airlie <airlied@...il.com>, Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>, Paolo Abeni <pabeni@...hat.com>, devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, netdev@...r.kernel.org, NXP Linux Team <linux-imx@....com>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH 2/6] dt-bindings: imx-thermal: Add
 #thermal-sensor-cells property

On Thu, 10 Aug 2023 16:44:47 +0200, Alexander Stein wrote:
> This property is defined in thermal-sensor.yaml. Reference this file and
> constraint '#thermal-sensor-cells' to 0 for imx-thermal.
> Fixes the warning:
> arch/arm/boot/dts/nxp/imx/imx6q-mba6a.dtb: tempmon:
>  '#thermal-sensor-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
>  From schema: Documentation/devicetree/bindings/thermal/imx-thermal.yaml
> 
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
>  Documentation/devicetree/bindings/thermal/imx-thermal.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb: tempmon: '#thermal-sensor-cells' is a required property
	from schema $id: http://devicetree.org/schemas/thermal/imx-thermal.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810144451.1459985-3-alexander.stein@ew.tq-group.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.