| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230811161509.19722-1-larysa.zaremba@intel.com> Date: Fri, 11 Aug 2023 18:14:48 +0200 From: Larysa Zaremba <larysa.zaremba@...el.com> To: bpf@...r.kernel.org Cc: Larysa Zaremba <larysa.zaremba@...el.com>, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org, yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org, David Ahern <dsahern@...il.com>, Jakub Kicinski <kuba@...nel.org>, Willem de Bruijn <willemb@...gle.com>, Jesper Dangaard Brouer <brouer@...hat.com>, Anatoly Burakov <anatoly.burakov@...el.com>, Alexander Lobakin <alexandr.lobakin@...el.com>, Magnus Karlsson <magnus.karlsson@...il.com>, Maryam Tahhan <mtahhan@...hat.com>, xdp-hints@...-project.net, netdev@...r.kernel.org, Willem de Bruijn <willemdebruijn.kernel@...il.com>, Alexei Starovoitov <alexei.starovoitov@...il.com>, Simon Horman <simon.horman@...igine.com> Subject: [PATCH bpf-next v5 00/21] XDP metadata via kfuncs for ice This series introduces XDP hints via kfuncs [0] to the ice driver. Series brings the following existing hints to the ice driver: - HW timestamp - RX hash with type Series also introduces new hints and adds their implementation to ice and veth: - VLAN tag with protocol - Checksum status The data above can now be accessed by XDP and userspace (AF_XDP) programs. They can also be checked with xdp_metadata test and xdp_hw_metadata program. [0] https://patchwork.kernel.org/project/netdevbpf/cover/20230119221536.3349901-1-sdf@google.com/ v4: https://lore.kernel.org/bpf/20230728173923.1318596-1-larysa.zaremba@intel.com/ v3: https://lore.kernel.org/bpf/20230719183734.21681-1-larysa.zaremba@intel.com/ v2: https://lore.kernel.org/bpf/20230703181226.19380-1-larysa.zaremba@intel.com/ v1: https://lore.kernel.org/all/20230512152607.992209-1-larysa.zaremba@intel.com/ Changes since v4: - Drop the concept of partial checksum from the hint design - Drop the concept of checksum level from the hint design Changes since v3: - use XDP_CHECKSUM_VALID_LVL0 + csum_level instead of csum_level + 1 - fix spelling mistakes - read XDP timestamp unconditionally - add TO_STR() macro Changes since v2: - redesign checksum hint, so now it gives full status - rename vlan_tag -> vlan_tci, where applicable - use open_netns() and close_netns() in xdp_metadata - improve VLAN hint documentation - replace CFI with DEI - use VLAN_VID_MASK in xdp_metadata - make vlan_get_tag() return -ENODATA - remove unused rx_ptype in ice_xsk.c - fix ice timestamp code division between patches Changes since v1: - directly return RX hash, RX timestamp and RX checksum status in skb-common functions - use intermediate enum value for checksum status in ice - get rid of ring structure dependency in ice kfunc implementation - make variables const, when possible, in ice implementation - use -ENODATA instead of -EOPNOTSUPP for driver implementation - instead of having 2 separate functions for c-tag and s-tag, use 1 function that outputs both VLAN tag and protocol ID - improve documentation for introduced hints - update xdp_metadata selftest to test new hints - implement new hints in veth, so they can be tested in xdp_metadata - parse VLAN tag in xdp_hw_metadata Aleksander Lobakin (1): net, xdp: allow metadata > 32 Larysa Zaremba (20): ice: make RX hash reading code more reusable ice: make RX HW timestamp reading code more reusable ice: make RX checksum checking code more reusable ice: Make ptype internal to descriptor info processing ice: Introduce ice_xdp_buff ice: Support HW timestamp hint ice: Support RX hash XDP hint ice: Support XDP hints in AF_XDP ZC mode xdp: Add VLAN tag hint ice: Implement VLAN tag hint ice: use VLAN proto from ring packet context in skb path xdp: Add checksum hint ice: Implement checksum hint selftests/bpf: Allow VLAN packets in xdp_hw_metadata selftests/bpf: Add flags and new hints to xdp_hw_metadata veth: Implement VLAN tag and checksum XDP hint net: make vlan_get_tag() return -ENODATA instead of -EINVAL selftests/bpf: Use AF_INET for TX in xdp_metadata selftests/bpf: Check VLAN tag and proto in xdp_metadata selftests/bpf: check checksum state in xdp_metadata Documentation/networking/xdp-rx-metadata.rst | 11 +- drivers/net/ethernet/intel/ice/ice.h | 2 + drivers/net/ethernet/intel/ice/ice_ethtool.c | 2 +- .../net/ethernet/intel/ice/ice_lan_tx_rx.h | 412 +++++++++--------- drivers/net/ethernet/intel/ice/ice_lib.c | 2 +- drivers/net/ethernet/intel/ice/ice_main.c | 23 + drivers/net/ethernet/intel/ice/ice_ptp.c | 27 +- drivers/net/ethernet/intel/ice/ice_ptp.h | 15 +- drivers/net/ethernet/intel/ice/ice_txrx.c | 19 +- drivers/net/ethernet/intel/ice/ice_txrx.h | 29 +- drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 343 ++++++++++++--- drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 18 +- drivers/net/ethernet/intel/ice/ice_xsk.c | 26 +- drivers/net/veth.c | 42 ++ include/linux/if_vlan.h | 4 +- include/linux/skbuff.h | 13 +- include/net/xdp.h | 29 +- kernel/bpf/offload.c | 4 + net/core/xdp.c | 57 +++ .../selftests/bpf/prog_tests/xdp_metadata.c | 187 ++++---- .../selftests/bpf/progs/xdp_hw_metadata.c | 48 +- .../selftests/bpf/progs/xdp_metadata.c | 16 + tools/testing/selftests/bpf/testing_helpers.h | 3 + tools/testing/selftests/bpf/xdp_hw_metadata.c | 67 ++- tools/testing/selftests/bpf/xdp_metadata.h | 42 +- 25 files changed, 995 insertions(+), 446 deletions(-) -- 2.41.0
Powered by blists - more mailing lists