| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3fc59b72-65fb-66e3-e291-ec20d1f468d4@kernel.org> Date: Fri, 11 Aug 2023 18:26:29 +0300 From: Roger Quadros <rogerq@...nel.org> To: Vladimir Oltean <vladimir.oltean@....com> Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, s-vadapalli@...com, srk@...com, vigneshr@...com, p-varis@...com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support Hi Vladimir, On 10/08/2023 18:47, Vladimir Oltean wrote: > Hi Roger, > > On Thu, Aug 10, 2023 at 06:25:38PM +0300, Roger Quadros wrote: >> Add driver support for viewing / changing the MAC Merge sublayer >> parameters and seeing the verification state machine's current state >> via ethtool. >> >> As hardware does not support interrupt notification for verification >> events we resort to polling on link up. On link up we try a couple of >> times for verification success and if unsuccessful then give up. >> >> The Frame Preemption feature is described in the Technical Reference >> Manual [1] in section: >> 12.3.1.4.6.7 Intersperced Express Traffic (IET – P802.3br/D2.0) >> >> Due to Silicon Errata i2208 [2] we set limit min IET fragment size to 124. >> >> [1] AM62x TRM - https://www.ti.com/lit/ug/spruiv7a/spruiv7a.pdf >> [2] AM62x Silicon Errata - https://www.ti.com/lit/er/sprz487c/sprz487c.pdf >> >> Signed-off-by: Roger Quadros <rogerq@...nel.org> >> --- >> >> Hi, >> >> Dropping the RFC tag as I now have MAC merge verification and frame >> preemption working. >> >> Changelog: >> v2: >> - Use proper control bits for PMAC enable (AM65_CPSW_PN_CTL_IET_PORT_EN) >> and TX enable (AM65_CPSW_PN_IET_MAC_PENABLE) >> - Common IET Enable (AM65_CPSW_CTL_IET_EN) is set if any port has >> AM65_CPSW_PN_CTL_IET_PORT_EN set. >> - Fix workaround for erratum i2208. i.e. Limit rx_min_frag_size to 124 >> - Fix am65_cpsw_iet_get_verify_timeout_ms() to default to timeout for >> 1G link if link is inactive. >> - resize the RX FIFO based on pmac_enabled, not tx_enabled. >> >> Test Procedure: >> >> - 2 EVMs with AM65-CPSW network port connected to each other >> - Run iet-setup.sh on both >> >> #!/bin/sh >> #iet-setup.sh >> >> ifconfig eth0 down >> ifconfig eth1 down >> ethtool -L eth0 tx 2 >> ethtool --set-priv-flags eth0 p0-rx-ptype-rrobin off >> ethtool --set-mm eth0 pmac-enabled on tx-enabled on verify-enabled on verify-time 10 tx-min-frag-size 124 >> ifconfig eth0 up >> sleep 10 >> >> tc qdisc replace dev eth0 handle 8001: parent root stab overhead 24 taprio \ >> num_tc 2 \ >> map 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 \ >> queues 1@0 1@1 \ >> base-time 0 \ >> sched-entry S 01 1216 \ >> sched-entry S fe 12368 \ >> flags 0x2 \ >> fp P E E E E E E E >> >> tc -g class show dev eth0 >> tc qdisc add dev eth0 clsact >> tc filter add dev eth0 egress protocol ip prio 1 u32 match ip dport 5002 0xffff action skbedit priority 2 >> tc filter add dev eth0 egress protocol ip prio 1 u32 match ip dport 5003 0xffff action skbedit priority 3 >> >> - check that MAC merge verification has succeeded >> >> ethtool --show-mm eth0 >> >> MAC Merge layer state for eth0: >> pMAC enabled: on >> TX enabled: on >> TX active: on >> TX minimum fragment size: 124 >> RX minimum fragment size: 124 >> Verify enabled: on >> Verify time: 10 >> Max verify time: 134 >> Verification status: SUCCEEDED > > Do you also plan to add support for mqprio, to present the same feature > set as everyone, and permit IET to be used without EST? Yes. I'll try to include it in next spin. > > What else would need to change in order for the am65 cpsw to > successfully run the existing tools/testing/selftests/net/forwarding/ethtool_mm.sh? > Just the extra driver-specific ethtool --set-priv-flags? If so, maybe > you could create a wrapper over the generic selftest, and put it in > tools/testing/selftests/drivers/net/. For DSA we also symlink a lot of > bridge selftests, for example. OK. I'll give it a try. > >> - On receiver EVM run 2 iperf instances >> >> iperf3 -s -i30 -p5002& >> iperf3 -s -i30 -p5003& >> >> - On sender EVM run 2 iperf instances >> >> iperf3 -c 192.168.3.102 -u -b200M -l1472 -u -t5 -i30 -p5002& >> iperf3 -c 192.168.3.102 -u -b50M -l1472 -u -t5 -i30 -p5003& >> >> - Check IET stats on sender. Look for iet_tx_frag increments >> >> ethtool -S eth0 | grep iet >> >> iet_rx_assembly_err: 0 >> iet_rx_assembly_ok: 0 >> iet_rx_smd_err: 0 >> iet_rx_frag: 0 >> iet_tx_hold: 0 >> iet_tx_frag: 17307 > > Can you please also implement the standardized ethtool_ops :: get_mm_stats()? > You can see these with ethtool -I --show-mm eth0. Yes. > >> >> - Check IET stats on receiver. Look for iet_rx_frag and iet_rx_assembly_* >> >> ethtool -S eth0 | grep iet >> >> iet_rx_assembly_err: 0 > > This would be struct ethtool_mm_stats :: MACMergeFrameAssErrorCount > >> iet_rx_assembly_ok: 17302 > > This would be struct ethtool_mm_stats :: MACMergeFrameAssOkCount > >> iet_rx_smd_err: 0 > > This would be struct ethtool_mm_stats :: MACMergeFrameSmdErrorCount > >> iet_rx_frag: 17307 > > This would be struct ethtool_mm_stats :: MACMergeFragCountRx > >> iet_tx_hold: 0 > > This would be struct ethtool_mm_stats :: MACMergeHoldCount > >> iet_tx_frag: 0 > > This would be struct ethtool_mm_stats :: MACMergeFragCountTx > Thanks for the hints :) > Also, I opened the AM62x datasheet again and I didn't find this, but I > still need to ask. The CPSW doesn't show the Ethernet counters broken > down by eMAC/pMAC, no? If it does, you should also add support for the > following: I don't think it does. > > ethtool -I --show-pause eth0 --src pmac > ethtool -S eth0 --groups eth-mac eth-phy eth-ctrl rmon -- --src pmac -- cheers, -roger
Powered by blists - more mailing lists