netdev - Re: [PATCH] Fix kernel panic issue after removing igb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33708eb5-d64f-53b4-5107-8f663ca22c4f@linux.dev>
Date: Fri, 11 Aug 2023 17:12:08 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: marshall.shao@...l.com, Jesse Brandeburg <jesse.brandeburg@...el.com>,
 Tony Nguyen <anthony.l.nguyen@...el.com>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Jacob Keller <jacob.e.keller@...el.com>,
 Simon Horman <simon.horman@...igine.com>,
 Akihiko Odaki <akihiko.odaki@...nix.com>, Kees Cook <keescook@...omium.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Aleksandr Loktionov <aleksandr.loktionov@...el.com>,
 Lin Ma <linma@....edu.cn>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix kernel panic issue after removing igb driver

On 11/08/2023 13:02, marshall.shao@...l.com wrote:
> From: Marshall Shao <Marshall.Shao@...l.com>
> 
> This patch fixes a kernel panic issue after removing the igb driver
> from the usermode.
> 
> A delayed work will be schedule in igb_ptp_init(),
> 
> 	if (adapter->ptp_flags & IGB_PTP_OVERFLOW_CHECK)
> 		INIT_DELAYED_WORK(&adapter->ptp_overflow_work,
> 				  igb_ptp_overflow_check);
> 
> If CONFIG_PTP_1588_CLOCK is not enabled, the delayed work cannot be
> cancelled when igb_ptp_suspend is called.

But should this work be inited in case there is no PTP support in the
kernel? Maybe it's better to avoid any driver threads in this case and
move the initialization to the if block where we know that PHC device
is created and working?

> 
> Signed-off-by: Marshall Shao <Marshall.Shao@...l.com>
> ---
>   drivers/net/ethernet/intel/igb/igb_ptp.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ptp.c b/drivers/net/ethernet/intel/igb/igb_ptp.c
> index 405886ee5261..b21822ea1c7d 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ptp.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ptp.c
> @@ -1435,12 +1435,12 @@ void igb_ptp_sdp_init(struct igb_adapter *adapter)
>    */
>   void igb_ptp_suspend(struct igb_adapter *adapter)
>   {
> -	if (!(adapter->ptp_flags & IGB_PTP_ENABLED))
> -		return;
> -
>   	if (adapter->ptp_flags & IGB_PTP_OVERFLOW_CHECK)
>   		cancel_delayed_work_sync(&adapter->ptp_overflow_work);
>   
> +	if (!(adapter->ptp_flags & IGB_PTP_ENABLED))
> +		return;
> +
>   	cancel_work_sync(&adapter->ptp_tx_work);
>   	if (adapter->ptp_tx_skb) {
>   		dev_kfree_skb_any(adapter->ptp_tx_skb);