lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ed096dfe-6a42-4838-972b-7a28afaf2f6e@lunn.ch> Date: Fri, 11 Aug 2023 18:39:00 +0200 From: Andrew Lunn <andrew@...n.ch> To: Vadim Fedorenko <vadim.fedorenko@...ux.dev> Cc: Daniel Golle <daniel@...rotopia.org>, Qingfang Deng <dqfext@...il.com>, SkyLake Huang <SkyLake.Huang@...iatek.com>, Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org Subject: Re: [PATCH net-next] net: phy: mediatek-ge-soc: support PHY LEDs > > + /* Only now setup pinctrl to avoid bogus blinking */ > > + pinctrl = devm_pinctrl_get_select(&phydev->mdio.dev, "gbe-led"); > > This function gets reference on phydev->mdio.dev, but there is no code > to release it. It looks like a leak which will prevent module unload, > but I don't have hardware now to prove it. Since it is a devm_ function, it should get released when the device is destroyed. Or am i missing something? Andrew
Powered by blists - more mailing lists