lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87e35743-f7d1-13de-45c0-3f50181abf5b@kernel.org> Date: Fri, 11 Aug 2023 22:06:11 +0200 From: Jesper Dangaard Brouer <hawk@...nel.org> To: Liang Chen <liangchen.linux@...il.com>, horms@...nel.org, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, linyunsheng@...wei.com Cc: hawk@...nel.org, ilias.apalodimas@...aro.org, daniel@...earbox.net, ast@...nel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: veth: Page pool creation error handling for existing pools only On 11/08/2023 14.16, Liang Chen wrote: > The failure handling procedure destroys page pools for all queues, > including those that haven't had their page pool created yet. this patch > introduces necessary adjustments to prevent potential risks and > inconsistency with the error handling behavior. > > Acked-by: Jesper Dangaard Brouer <hawk@...nel.org> > Signed-off-by: Liang Chen <liangchen.linux@...il.com> > --- Fixes: 0ebab78cbcbf ("net: veth: add page_pool for page recycling") But not a critical fix, so net-next is okay. > drivers/net/veth.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/veth.c b/drivers/net/veth.c > index 614f3e3efab0..509e901da41d 100644 > --- a/drivers/net/veth.c > +++ b/drivers/net/veth.c > @@ -1081,8 +1081,9 @@ static int __veth_napi_enable_range(struct net_device *dev, int start, int end) > err_xdp_ring: > for (i--; i >= start; i--) > ptr_ring_cleanup(&priv->rq[i].xdp_ring, veth_ptr_free); > + i = end; > err_page_pool: > - for (i = start; i < end; i++) { > + for (i--; i >= start; i--) { > page_pool_destroy(priv->rq[i].page_pool); > priv->rq[i].page_pool = NULL; > }
Powered by blists - more mailing lists