netdev - Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter atomic update feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230811150449.64ce3512@kernel.org>
Date: Fri, 11 Aug 2023 15:04:49 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Sai Krishna Gajula <saikrishnag@...vell.com>
Cc: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "pabeni@...hat.com" <pabeni@...hat.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Sunil
 Kovvuri Goutham <sgoutham@...vell.com>, Geethasowjanya Akula
 <gakula@...vell.com>, Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
 Hariprasad Kelam <hkelam@...vell.com>, "richardcochran@...il.com"
 <richardcochran@...il.com>, Naveen Mamindlapalli <naveenm@...vell.com>
Subject: Re: [net-next PATCH v2] octeontx2-pf: Use PTP HW timestamp counter
 atomic update feature

On Fri, 11 Aug 2023 05:48:38 +0000 Sai Krishna Gajula wrote:
> > If you reorder the includes - maybe put them in alphabetical order?  
> 
> There are some structure definitions in rvu.h which are required in
> ptp.h. So, re-ordering in alphabetical order will give compilation
> issue. 

Headers should be self-contained. Such dependencies are hard to figure
out for people doing refactoring so it'd be best to clean that up.