netdev - Re: [EXT] Re: [PATCH v2 net] qede: fix firmware halt over suspend and resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230811144507.5ab3fdae@kernel.org>
Date: Fri, 11 Aug 2023 14:45:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Manish Chopra <manishc@...vell.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Ariel Elior
 <aelior@...vell.com>, Alok Prasad <palok@...vell.com>, Nilesh Javali
 <njavali@...vell.com>, Saurav Kashyap <skashyap@...vell.com>,
 "jmeneghi@...hat.com" <jmeneghi@...hat.com>, "yuval.mintz@...gic.com"
 <yuval.mintz@...gic.com>, Sudarsana Reddy Kalluru <skalluru@...vell.com>,
 "pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
 <edumazet@...gle.com>, "horms@...nel.org" <horms@...nel.org>, David Miller
 <davem@...emloft.net>
Subject: Re: [EXT] Re: [PATCH v2 net] qede: fix firmware halt over suspend
 and resume

On Fri, 11 Aug 2023 09:31:15 +0000 Manish Chopra wrote:
> > Does the FW end up recovering? That could still be preferable to rejecting
> > suspend altogether. Reject is a big hammer, I'm a bit worried it will cause a
> > regression in stable.  
> 
> Yes, By adding the driver's suspend handler with explicit error returned 
> to PCI subsystem prevents the system wide suspend and does not impact the
> device/FW at all. It keeps them operational as they were before.

I'm asking about recovery without this patch, not with it.
That should be evident from the text I'm replying under.