lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230811121420.00007a95@gmail.com> Date: Fri, 11 Aug 2023 12:14:20 +0800 From: Furong Xu <0x1207@...il.com> To: Andrew Lunn <andrew@...n.ch> Cc: "David S. Miller" <davem@...emloft.net>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Joao Pinto <jpinto@...opsys.com>, Simon Horman <horms@...nel.org>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, xfr@...look.com, rock.xu@....com Subject: Re: [PATCH 1/1] net: stmmac: dwmac4: extract MAC_HW_Feature regs MSB first On Thu, 10 Aug 2023 15:59:25 +0200 Andrew Lunn <andrew@...n.ch> wrote: > On Thu, Aug 10, 2023 at 05:59:29PM +0800, Furong Xu wrote: > > The bit extraction sequences are a little messy. > > No code changes, just reorder them. > > How is this substantially better? > > If bugs are found in this code, your change is going to make it harder > to back port the fixes to stable kernels. cherry-pick is unlikely to > work, it will need a human to look at it. Not hard, but still effort > for somebody. > > So i think there needs to be a clear benefit to this, and you should > mention the benefit in the commit message. > > Andrew Hi Andrew, Alexandre In Synopsys databook, the description tables about all registers start with the MSB. So we can read one line code and then check it against one table row, and goto next line of code against next row of table. I agree with that this commit make cherry-pick less compatible. If the benefit above is not worthy enough, we abandon this commit :) Thanks.
Powered by blists - more mailing lists