netdev - Re: [PATCH] net: phy: broadcom: stub c45 read/write for 54810

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73951864-6632-1a67-5c7e-a96586429429@broadcom.com>
Date: Fri, 11 Aug 2023 16:54:20 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Justin Chen <justin.chen@...adcom.com>
Cc: netdev@...r.kernel.org,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>,
 Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: phy: broadcom: stub c45 read/write for 54810

On 8/11/2023 4:47 PM, Justin Chen wrote:
> On Fri, Aug 11, 2023 at 4:40 PM Florian Fainelli
> <florian.fainelli@...adcom.com> wrote:
>>
>>
>>
>> On 8/11/2023 4:29 PM, Justin Chen wrote:
>>> The 54810 does not support c45. The mmd_phy_indirect accesses return
>>> arbirtary values leading to odd behavior like saying it supports EEE
>>> when it doesn't. We also see that reading/writing these non-existent
>>> MMD registers leads to phy instability in some cases.
>>>
>>> Signed-off-by: Justin Chen <justin.chen@...adcom.com>
>>
>> Thanks for submitting this fix, I would be tempted to slap a:
>>
>> Fixes: b14995ac2527 ("net: phy: broadcom: Add BCM54810 PHY entry")
>>
>> so we get it back ported to stable trees where appropriate. It is not
>> clear whether we should return -EINVAL vs. -EOPNOTSUPP which may more
>> clearly indicate the inability to support MMD registers?
> 
> Hmm agreed EOPNOTSUPP seems better here. Will submit v2 with fixes tag
> if there are no objections to this patch.

Since this is a fix, you will want to use [PATCH net] as the subject 
prefix per:

https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

and wait 24hrs in case someone provides additional review that you can 
incorporate in your v2.
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)