netdev - Re: [PATCH net V2] virtio-net: set queues after driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230811182344.763f10da@kernel.org>
Date: Fri, 11 Aug 2023 18:23:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jason Wang <jasowang@...hat.com>
Cc: mst@...hat.com, xuanzhuo@...ux.alibaba.com, davem@...emloft.net,
 edumazet@...gle.com, pabeni@...hat.com,
 virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, Dragos
 Tatulea <dtatulea@...dia.com>
Subject: Re: [PATCH net V2] virtio-net: set queues after driver_ok

On Wed,  9 Aug 2023 23:12:56 -0400 Jason Wang wrote:
> Commit 25266128fe16 ("virtio-net: fix race between set queues and
> probe") tries to fix the race between set queues and probe by calling
> _virtnet_set_queues() before DRIVER_OK is set. This violates virtio
> spec. Fixing this by setting queues after virtio_device_ready().
> 
> Note that rtnl needs to be held for userspace requests to change the
> number of queues. So we are serialized in this way.

FTR this appears to have been applied yesterday by DaveM. Thanks!