netdev - Re: [PATCH net] Revert "vlan: Fix VLAN 0 memory leak"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNiIyjStj71S5/Rs@shredder>
Date: Sun, 13 Aug 2023 10:39:54 +0300
From: Ido Schimmel <idosch@...sch.org>
To: Vlad Buslov <vladbu@...dia.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
	pabeni@...hat.com, netdev@...r.kernel.org, amir.hanania@...el.com,
	jeffrey.t.kirsher@...el.com, john.fastabend@...il.com,
	horms@...nel.org,
	syzbot+662f783a5cdf3add2719@...kaller.appspotmail.com,
	syzbot+4b4f06495414e92701d5@...kaller.appspotmail.com,
	syzbot+d810d3cd45ed1848c3f7@...kaller.appspotmail.com
Subject: Re: [PATCH net] Revert "vlan: Fix VLAN 0 memory leak"

On Fri, Aug 11, 2023 at 05:45:23PM +0200, Vlad Buslov wrote:
> This reverts commit 718cb09aaa6fa78cc8124e9517efbc6c92665384.
> 
> The commit triggers multiple syzbot issues, probably due to possibility of
> manually creating VLAN 0 on netdevice which will cause the code to delete
> it since it can't distinguish such VLAN from implicit VLAN 0 automatically
> created for devices with NETIF_F_HW_VLAN_CTAG_FILTER feature.
> 
> Reported-by: syzbot+662f783a5cdf3add2719@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/all/00000000000090196d0602a6167d@google.com/
> Reported-by: syzbot+4b4f06495414e92701d5@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/all/00000000000096ae870602a61602@google.com/
> Reported-by: syzbot+d810d3cd45ed1848c3f7@...kaller.appspotmail.com
> Closes: https://lore.kernel.org/all/0000000000009f0f9c0602a616ce@google.com/
> Fixes: 718cb09aaa6f ("vlan: Fix VLAN 0 memory leak")
> Signed-off-by: Vlad Buslov <vladbu@...dia.com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>