netdev - Re: [PATCH] qed: remove unused 'resp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230814101312.GF3921@unreal>
Date: Mon, 14 Aug 2023 13:13:12 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Ariel Elior <aelior@...vell.com>, Manish Chopra <manishc@...vell.com>,
	Arnd Bergmann <arnd@...db.de>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Tom Rix <trix@...hat.com>, Yuval Mintz <Yuval.Mintz@...gic.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev
Subject: Re: [PATCH] qed: remove unused 'resp_size' calculation

On Mon, Aug 14, 2023 at 09:45:03AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Newer versions of clang warn about this variable being assigned but
> never used:
> 
> drivers/net/ethernet/qlogic/qed/qed_vf.c:63:67: error: parameter 'resp_size' set but not used [-Werror,-Wunused-but-set-parameter]
> 
> There is no indication in the git history on how this was ever
> meant to be used, so just remove the entire calculation and argument
> passing for it to avoid the warning.
> 
> Fixes: 1408cc1fa48c5 ("qed: Introduce VFs")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_vf.c | 45 +++++++++---------------
>  1 file changed, 17 insertions(+), 28 deletions(-)
> 

I don't think that Fixes tag is really needed here and title should be [PATCH
net] or [PATCH net-next].

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>