netdev - Re: [PATCH net-next] tun: add __exit annotations to module exit func tun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230814120515.GH3921@unreal>
Date: Mon, 14 Aug 2023 15:05:15 +0300
From: Leon Romanovsky <leon@...nel.org>
To: "Ziyang Xuan (William)" <william.xuanziyang@...wei.com>
Cc: willemdebruijn.kernel@...il.com, jasowang@...hat.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tun: add __exit annotations to module exit func
 tun_cleanup()

On Mon, Aug 14, 2023 at 07:27:59PM +0800, Ziyang Xuan (William) wrote:
> > On Mon, Aug 14, 2023 at 04:30:00PM +0800, Ziyang Xuan wrote:
> >> Add missing __exit annotations to module exit func tun_cleanup().
> >>
> >> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>
> >> ---
> >>  drivers/net/tun.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> >> index 973b2fc74de3..291c118579a9 100644
> >> --- a/drivers/net/tun.c
> >> +++ b/drivers/net/tun.c
> >> @@ -3740,7 +3740,7 @@ static int __init tun_init(void)
> >>  	return ret;
> >>  }
> >>  
> >> -static void tun_cleanup(void)
> >> +static void __exit tun_cleanup(void)
> > 
> > Why __exit and not __net_exit?
> 
> tun_cleanup() is a module exit function. it corresponds to tun_init().
> tun_init() uses __init, so tun_cleanup() uses __exit.

__net_init is equal to __init.

> 
> Thank you!
> William Xuan
> > 
> > Thanks
> > 
> >>  {
> >>  	misc_deregister(&tun_miscdev);
> >>  	rtnl_link_unregister(&tun_link_ops);
> >> -- 
> >> 2.25.1
> >>
> >>
> > .
> >