netdev - RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230814181354.8603-1-rohan.g.thomas@intel.com>
Date: Tue, 15 Aug 2023 02:13:54 +0800
From: rohan.g.thomas@...el.com
To: jose.abreu@...opsys.com
Cc: alexandre.torgue@...s.st.com,
	conor+dt@...nel.org,
	davem@...emloft.net,
	devicetree@...r.kernel.org,
	edumazet@...gle.com,
	krzysztof.kozlowski+dt@...aro.org,
	kuba@...nel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	mcoquelin.stm32@...il.com,
	netdev@...r.kernel.org,
	pabeni@...hat.com,
	peppe.cavallaro@...com,
	robh+dt@...nel.org,
	Rohan G Thomas <rohan.g.thomas@...el.com>
Subject: RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback

From: Rohan G Thomas <rohan.g.thomas@...el.com>

From: Rohan G Thomas <rohan.g.thomas@...el.com>
Date: Mon, Aug 14, 2023 at 15:06:37
> 
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
> > @@ -219,6 +219,8 @@ struct stmmac_priv {
> >  	int hwts_tx_en;
> >  	bool tx_path_in_lpi_mode;
> >  	bool tso;
> > +	bool tx_q_coe_lmt;
> 
> Please use a flag here instead of "tx_q_coe_lmt". This is the preferrable
> method now.
> 
> Thanks,
> Jose

Thanks Jose for the feedback. If I read that correctly, your
suggestion is to change " tx_q_coe_lmt" to something more readable,
like "has_txcoe_limit". Please correct me if I understand it wrongly.

BR,
Rohan

> 
> > +	u32 tx_q_with_coe;
> >  	int sph;
> >  	int sph_cap;
> >  	u32 sarc_type;