netdev - Re: [PATCH net-next] net: e1000e: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 14 Aug 2023 15:19:10 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Yue Haibing <yuehaibing@...wei.com>, <jesse.brandeburg@...el.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: e1000e: Remove unused declarations

On 8/14/2023 6:58 AM, Yue Haibing wrote:
> Commit bdfe2da6aefd ("e1000e: cosmetic move of function prototypes to the new mac.h")
> declared but never implemented them.
> 
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

I believe netdev has been taking all these unused declaration patches 
directly so...

Reviewed-by: Tony Nguyen <anthony.l.nguyen@...el.com>

> ---
>   drivers/net/ethernet/intel/e1000e/mac.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/mac.h b/drivers/net/ethernet/intel/e1000e/mac.h
> index 6ab261119801..563176fd436e 100644
> --- a/drivers/net/ethernet/intel/e1000e/mac.h
> +++ b/drivers/net/ethernet/intel/e1000e/mac.h
> @@ -29,8 +29,6 @@ s32 e1000e_set_fc_watermarks(struct e1000_hw *hw);
>   s32 e1000e_setup_fiber_serdes_link(struct e1000_hw *hw);
>   s32 e1000e_setup_led_generic(struct e1000_hw *hw);
>   s32 e1000e_setup_link_generic(struct e1000_hw *hw);
> -s32 e1000e_validate_mdi_setting_generic(struct e1000_hw *hw);
> -s32 e1000e_validate_mdi_setting_crossover_generic(struct e1000_hw *hw);
>   
>   void e1000e_clear_hw_cntrs_base(struct e1000_hw *hw);
>   void e1000_clear_vfta_generic(struct e1000_hw *hw);