netdev - Re: [PATCH -next] hv_netvsc: Remove duplicated include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7a6c71a-98a6-64cd-8118-2b0f89189177@huawei.com>
Date: Mon, 14 Aug 2023 09:56:11 +0800
From: "Guozihua (Scott)" <guozihua@...wei.com>
To: Simon Horman <horms@...nel.org>
CC: <kys@...rosoft.com>, <haiyangz@...rosoft.com>, <wei.liu@...nel.org>,
	<decui@...rosoft.com>, <linux-hyperv@...r.kernel.org>,
	<netdev@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet
	<edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>, Paolo Abeni
	<pabeni@...hat.com>
Subject: Re: [PATCH -next] hv_netvsc: Remove duplicated include

On 2023/8/11 17:14, Simon Horman wrote:
> On Thu, Aug 10, 2023 at 07:51:48PM +0800, GUO Zihua wrote:
>> Remove duplicated include of linux/slab.h.  Resolves checkincludes message.
>>
>> Signed-off-by: GUO Zihua <guozihua@...wei.com>
> 
> The patch looks fine, but for reference, I do have some feedback
> from a process point of view. It's probably not necessary to
> repost because of these. But do keep them in mind if you have
> to post a v2 for some other reason, and for future patch submissions.
> 
> * As a non bugfix for Networking code this should likely be targeted
>   at the net-next tree - the net tree is used for bug fixes.
>   And the target tree should be noted in the subject.
> 
>   Subject: [PATCH net-next] ...
> 
> * Please use the following command to generate the
>   CC list for Networking patches
> 
>   ./scripts/get_maintainer.pl --git-min-percent 2 this.patch
> 
>   In this case, the following, now CCed, should be included:
> 
>   - Jakub Kicinski <kuba@...nel.org>
>   - Eric Dumazet <edumazet@...gle.com>
>   - "David S. Miller" <davem@...emloft.net>
>   - Paolo Abeni <pabeni@...hat.com>
> 
> * Please do read the process guide
> 
>   https://kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
> The above notwithstanding,
> 
> Reviewed-by: Simon Horman <horms@...nel.org>

Hi Simon,

Thanks for the info and the review-by! Will keep that in mind.

-- 
Best
GUO Zihua