netdev - Re: [PATCH v3 net-next 00/15] inet: socket lock and data-races avoidance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 15 Aug 2023 09:51:20 +0200
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Simon Horman <simon.horman@...igine.com>,
	Soheil Hassas Yeganeh <soheil@...gle.com>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH v3 net-next 00/15] inet: socket lock and data-races
 avoidance

On Sat, Aug 12, 2023 at 09:33:29AM +0000, Eric Dumazet wrote:
> In this series, I converted 20 bits in "struct inet_sock" and made
> them truly atomic.
> 
> This allows to implement many IP_ socket options in a lockless
> fashion (no need to acquire socket lock), and fixes data-races
> that were showing up in various KCSAN reports.
> 
> I also took care of IP_TTL/IP_MINTTL, but left few other options
> for another series.
> 
> v3: fixed patch 7, feedback from build bot about ipvs set_mcast_loop()
> 
> v2: addressed a feedback from a build bot in patch 9 by removing
>  unused issk variable in mptcp_setsockopt_sol_ip_set_transparent()
>  Added Acked-by: tags from Soheil (thanks!)

For series,

Reviewed-by: Simon Horman <horms@...nel.org>