netdev - RE: [PATCH net-next] eth: r8152: try to use a normal budget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 15 Aug 2023 01:36:54 +0000
From: Hayes Wang <hayeswang@...ltek.com>
To: Jakub Kicinski <kuba@...nel.org>,
        "davem@...emloft.net"
	<davem@...emloft.net>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "Mario
 Limonciello" <mario.limonciello@....com>,
        "bjorn@...k.no" <bjorn@...k.no>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH net-next] eth: r8152: try to use a normal budget

akub Kicinski <kuba@...nel.org>
> Sent: Monday, August 14, 2023 11:35 PM
[...]
> Mario reports that loading r8152 on his system leads to a:
> 
>   netif_napi_add_weight() called with weight 256
> 
> warning getting printed. We don't have any solid data
> on why such high budget was chosen, and it may cause
> stalls in processing other softirqs and rt threads.
> So try to switch back to the default (64) weight.
> 
> If this slows down someone's system we should investigate
> which part of stopping starting the NAPI poll in this
> driver are expensive.
> 
> Reported-by: Mario Limonciello <mario.limonciello@....com>
> Link:
> https://lore.kernel.org/all/0bfd445a-81f7-f702-08b0-bd5a72095e49@amd.com
> /
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Acked-by: Hayes Wang <hayeswang@...ltek.com>

Best Regards,
Hayes