netdev - Re: [ovs-dev] [PATCH net-next v3 03/10] genetlink: remove userhdr from struct genl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7twmxwxygr.fsf@redhat.com>
Date: Tue, 15 Aug 2023 08:49:08 -0400
From: Aaron Conole <aconole@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  axboe@...nel.dk,  linux-block@...r.kernel.org,
  jiri@...nulli.us,  netdev@...r.kernel.org,  dev@...nvswitch.org,
  philipp.reisner@...bit.com,  jmaloy@...hat.com,
  christoph.boehmwalder@...bit.com,  edumazet@...gle.com,
  tipc-discussion@...ts.sourceforge.net,  Jiri Pirko <jiri@...dia.com>,
  ying.xue@...driver.com,  johannes@...solutions.net,  pabeni@...hat.com,
  drbd-dev@...ts.linbit.com,  lars.ellenberg@...bit.com,
  jacob.e.keller@...el.com
Subject: Re: [ovs-dev] [PATCH net-next v3 03/10] genetlink: remove userhdr
 from struct genl_info

Jakub Kicinski <kuba@...nel.org> writes:

> Only three families use info->userhdr today and going forward
> we discourage using fixed headers in new families.
> So having the pointer to user header in struct genl_info
> is an overkill. Compute the header pointer at runtime.
>
> Reviewed-by: Johannes Berg <johannes@...solutions.net>
> Reviewed-by: Jiri Pirko <jiri@...dia.com>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---

Seems the OVS side didn't change from v2 so still:

Reviewed-by: Aaron Conole <aconole@...hat.com>