netdev - Re: [PATCH net-next 1/2] igb: Stop PTP related workqueues if aren't necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <717f19cb-9b6a-bbc1-26d7-facab245bbf3@intel.com>
Date: Tue, 15 Aug 2023 08:24:29 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: Rahul Rameshbabu <rrameshbabu@...dia.com>, Leon Romanovsky
	<leon@...nel.org>
CC: <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<edumazet@...gle.com>, <netdev@...r.kernel.org>, Alessio Igor Bogani
	<alessio.bogani@...ttra.eu>, <richardcochran@...il.com>, "Pucha Himasekhar
 Reddy" <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 1/2] igb: Stop PTP related workqueues if aren't
 necessary



On 8/14/2023 10:46 PM, Rahul Rameshbabu wrote:
> 
> I do not think it's an issue for the work initialization to be after the
> call to ptp_clock_register after taking a quick read.
> 
> ptp_clock_register essentially sets up the needed infrastructure for the
> ptp hardware clock (PHC) and exposes the hardware clock to the
> userspace. None of the PHC operations seem to depend on scheduling work
> related to the ptp_tx_work and ptp_overflow_work work_struct instances
> from what I can tell. Essentially, the only case this order would matter
> is if any of the adapter->ptp_caps operation callbacks depends on
> scheduling related work. From what I can tell, this is not the case in
> the igb driver.

Thanks for clearing it up Rahul. I believe I have a version from Alessio 
that has the changes that Leon suggested, but it hasn't gone through 
validation yet. I'll drop this from this PR and will send that one after 
testing.

Thanks,
Tony