netdev - Re: [PATCH net-next] gve: add header split support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230814192231.12e0c290@kernel.org>
Date: Mon, 14 Aug 2023 19:22:31 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ziwei Xiao <ziweixiao@...gle.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, Jeroen de Borst
 <jeroendb@...gle.com>, Praveen Kaligineedi <pkaligineedi@...gle.com>,
 Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] gve: add header split support

On Fri, 11 Aug 2023 15:39:38 -0700 Ziwei Xiao wrote:
> - Add header-split and strict-header-split ethtool priv flags. These
>   flags control header-split behavior. It can be turned on/off and it
>   can be set to 'strict' which will cause the driver to drop all the
>   packets that don't have a proper header split.
> - Add max-rx-buffer-size priv flag to allow user to switch the packet
>   buffer size between max and default(e.g. 4K <-> 2K).
> - Add reconfigure rx rings to support the header split and
>   max-rx-buffer-size enable/disable switch.

Someone on your team needs to participate upstream or you need
to get your patches reviewed from someone upstream-savvy before
posting.

Anyone participating in netdev reviews would have told you that
private flags are unlikely to fly upstream.

One part of an organization participating upstream while another
has no upstream understanding and throws code over the wall is
a common anti-pattern, and I intend to stop it.
-- 
pw-bot: cr