netdev - Re: [PATCH v2 net] net: fix the RTO timer retransmitting skb every 1ms if linear option is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <169212782187.7072.16617221851171968021.git-patchwork-notify@kernel.org>
Date: Tue, 15 Aug 2023 19:30:21 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jason Xing <kerneljasonxing@...il.com>
Cc: edumazet@...gle.com, davem@...emloft.net, dsahern@...nel.org,
 kuba@...nel.org, pabeni@...hat.com, apetlund@...ula.no,
 netdev@...r.kernel.org, kernelxing@...cent.com
Subject: Re: [PATCH v2 net] net: fix the RTO timer retransmitting skb every 1ms if
 linear option is enabled

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Fri, 11 Aug 2023 10:37:47 +0800 you wrote:
> From: Jason Xing <kernelxing@...cent.com>
> 
> In the real workload, I encountered an issue which could cause the RTO
> timer to retransmit the skb per 1ms with linear option enabled. The amount
> of lost-retransmitted skbs can go up to 1000+ instantly.
> 
> The root cause is that if the icsk_rto happens to be zero in the 6th round
> (which is the TCP_THIN_LINEAR_RETRIES value), then it will always be zero
> due to the changed calculation method in tcp_retransmit_timer() as follows:
> 
> [...]

Here is the summary with links:
  - [v2,net] net: fix the RTO timer retransmitting skb every 1ms if linear option is enabled
    https://git.kernel.org/netdev/net/c/e4dd0d3a2f64

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html