netdev - Re: [Patch net, v2] net: xfrm: skip policies marked as dead while reinserting policies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230815060454.GA2833@breakpoint.cc>
Date: Tue, 15 Aug 2023 08:04:54 +0200
From: Florian Westphal <fw@...len.de>
To: Leon Romanovsky <leon@...nel.org>
Cc: Dong Chenchen <dongchenchen2@...wei.com>, steffen.klassert@...unet.com,
	herbert@...dor.apana.org.au, davem@...emloft.net, fw@...len.de,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	timo.teras@....fi, yuehaibing@...wei.com, weiyongjun1@...wei.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch net, v2] net: xfrm: skip policies marked as dead while
 reinserting policies

Leon Romanovsky <leon@...nel.org> wrote:
> >  		dir = xfrm_policy_id2dir(policy->index);
> > -		if (policy->walk.dead || dir >= XFRM_POLICY_MAX)
> > +		if (dir >= XFRM_POLICY_MAX)
> 
> This change is unnecessary, previous code was perfectly fine.

Are you sure? AFAICS walker struct has no 'index' member.