netdev - Re: [PATCH net] team: Fix incorrect deletion of ETH_P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZNsymO9HyhmFhDCJ@vergenet.net>
Date: Tue, 15 Aug 2023 10:08:56 +0200
From: Simon Horman <horms@...nel.org>
To: Ziyang Xuan <william.xuanziyang@...wei.com>
Cc: jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	idosch@...sch.org, kaber@...sh.net
Subject: Re: [PATCH net] team: Fix incorrect deletion of ETH_P_8021AD
 protocol vid from slaves

On Mon, Aug 14, 2023 at 11:23:01AM +0800, Ziyang Xuan wrote:
> Similar to commit 01f4fd270870 ("bonding: Fix incorrect deletion of
> ETH_P_8021AD protocol vid from slaves"), we can trigger BUG_ON(!vlan_info)
> in unregister_vlan_dev() with the following testcase:
> 
>   # ip netns add ns1
>   # ip netns exec ns1 ip link add team1 type team
>   # ip netns exec ns1 ip link add team_slave type veth peer veth2
>   # ip netns exec ns1 ip link set team_slave master team1
>   # ip netns exec ns1 ip link add link team_slave name team_slave.10 type vlan id 10 protocol 802.1ad
>   # ip netns exec ns1 ip link add link team1 name team1.10 type vlan id 10 protocol 802.1ad
>   # ip netns exec ns1 ip link set team_slave nomaster
>   # ip netns del ns1
> 
> Add S-VLAN tag related features support to team driver. So the team driver
> will always propagate the VLAN info to its slaves.
> 
> Fixes: 8ad227ff89a7 ("net: vlan: add 802.1ad support")
> Suggested-by: Ido Schimmel <idosch@...sch.org>
> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>

Reviewed-by: Simon Horman <horms@...nel.org>