netdev - Re: [PATCH net-next 2/3] netlink: specs: add ovs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 15 Aug 2023 09:06:56 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net,  netdev@...r.kernel.org,  edumazet@...gle.com,
  pabeni@...hat.com
Subject: Re: [PATCH net-next 2/3] netlink: specs: add ovs_vport new command

Jakub Kicinski <kuba@...nel.org> writes:

> Add NEW to the spec, it was useful testing the fix for OvS
> input validation.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: donald.hunter@...il.com
> ---
>  Documentation/netlink/specs/ovs_vport.yaml | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/netlink/specs/ovs_vport.yaml b/Documentation/netlink/specs/ovs_vport.yaml
> index 17336455bec1..ef298b001445 100644
> --- a/Documentation/netlink/specs/ovs_vport.yaml
> +++ b/Documentation/netlink/specs/ovs_vport.yaml
> @@ -81,6 +81,10 @@ uapi-header: linux/openvswitch.h
>      name-prefix: ovs-vport-attr-
>      enum-name: ovs-vport-attr
>      attributes:
> +      -
> +        name: unspec
> +        type: unused
> +        value: 0
>        -
>          name: port-no
>          type: u32
> @@ -120,6 +124,20 @@ uapi-header: linux/openvswitch.h
>  operations:
>    name-prefix: ovs-vport-cmd-
>    list:
> +    -
> +      name: new
> +      doc: Create a new OVS vport
> +      attribute-set: vport
> +      fixed-header: ovs-header
> +      do:
> +        request:
> +          attributes:
> +            - name
> +            - type
> +            - upcall-pid
> +            - dp-ifindex
> +            - ifindex
> +            - options
>      -
>        name: get
>        doc: Get / dump OVS vport configuration and state

Reviewed-by: Donald Hunter <donald.hunter@...il.com>