netdev - Re: [PATCH v4 net-next 09/15] inet: move inet->transparent to inet->inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bc75e20-da61-4dbe-9cc5-fe87860c94d0@tessares.net>
Date: Wed, 16 Aug 2023 11:15:14 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <simon.horman@...igine.com>,
 Soheil Hassas Yeganeh <soheil@...gle.com>, netdev@...r.kernel.org,
 eric.dumazet@...il.com, Simon Horman <horms@...nel.org>,
 MPTCP Upstream <mptcp@...ts.linux.dev>
Subject: Re: [PATCH v4 net-next 09/15] inet: move inet->transparent to
 inet->inet_flags

Hi Eric,

(+ Cc MPTCP ML)

On 16/08/2023 10:15, Eric Dumazet wrote:
> IP_TRANSPARENT socket option can now be set/read
> without locking the socket.
> 
> v2: removed unused issk variable in mptcp_setsockopt_sol_ip_set_transparent()
> v4: rebased after commit 3f326a821b99 ("mptcp: change the mpc check helper to return a sk")

Sorry for that, I didn't see your series sent to netdev was conflicting
with the one for MPTCP I sent in parallel.

> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
>  include/net/inet_sock.h       |  6 +++---
>  include/net/ipv6.h            |  2 +-
>  include/net/route.h           |  2 +-
>  include/net/tcp.h             |  2 +-
>  net/ipv4/inet_diag.c          |  2 +-
>  net/ipv4/inet_timewait_sock.c |  2 +-
>  net/ipv4/ip_sockglue.c        | 28 +++++++++++++---------------
>  net/ipv4/tcp_input.c          |  2 +-
>  net/ipv4/tcp_minisocks.c      |  3 +--
>  net/ipv6/ipv6_sockglue.c      |  4 ++--

The modifications in MPTCP code...

>  net/mptcp/sockopt.c           | 11 +++++------

... look good to me!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

>  11 files changed, 30 insertions(+), 34 deletions(-)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net