netdev - Re: [PATCH net-next] selftests: bonding: remove redundant delete action of device link1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0ef07c7-91b0-94bd-240d-944a330fcabd@huawei.com>
Date: Wed, 16 Aug 2023 17:22:38 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: Hangbin Liu <liuhangbin@...il.com>
CC: <netdev@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
	<shuah@...nel.org>, <j.vosburgh@...il.com>, <andy@...yhouse.net>,
	<weiyongjun1@...wei.com>, <yuehaibing@...wei.com>
Subject: Re: [PATCH net-next] selftests: bonding: remove redundant delete
 action of device link1_1



On 2023/8/16 16:33, Hangbin Liu wrote:
> On Wed, Aug 16, 2023 at 03:55:30PM +0800, shaozhengchao wrote:
>>
>>
>> On 2023/8/16 14:11, Hangbin Liu wrote:
>>> On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote:
>>>> When run command "ip netns delete client", device link1_1 has been
>>>> deleted. So, it is no need to delete link1_1 again. Remove it.
>>>
>> Hi Hangbin:
>>> What if the test exit because the cmd execute failed before setting
>>> link1_1 to netns client?
>>>
>>> Thanks
>>> Hangbin
>>>>
>> 	Your consideration is indeed possible.
>> "ip link del link1_1 >/dev/null 2>&1" maybe looks better?
> 
> I have not objects to this. On the other side, this only omit the error
> message. It doesn't fix anything.
> 
> Thanks
> Hangbin
	Yes, it will fix nothing, just clean up something.
I will add it later.

Also I run bond-break-lacpdu-tx.sh, it reports FAIL.
When the master is set up, the slave does not go up. It seems
that the mechanism has changed. But now I haven't had time
to analyze it in detail, maybe someone can do it.

Zhengchao Shao