netdev - Re: [PATCH v4 net-next 13/15] inet: move inet->defer_connect to inet->inet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1372659f-01a2-47a8-aa09-79687985bb72@tessares.net>
Date: Wed, 16 Aug 2023 11:15:38 +0200
From: Matthieu Baerts <matthieu.baerts@...sares.net>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
 <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: Simon Horman <simon.horman@...igine.com>,
 Soheil Hassas Yeganeh <soheil@...gle.com>, netdev@...r.kernel.org,
 eric.dumazet@...il.com, Simon Horman <horms@...nel.org>,
 MPTCP Upstream <mptcp@...ts.linux.dev>
Subject: Re: [PATCH v4 net-next 13/15] inet: move inet->defer_connect to
 inet->inet_flags

Hi Eric,

(+ Cc MPTCP ML)

On 16/08/2023 10:15, Eric Dumazet wrote:
> Make room in struct inet_sock by removing this bit field,
> using one available bit in inet_flags instead.
> 
> Also move local_port_range to fill the resulting hole,
> saving 8 bytes on 64bit arches.

Thank you for this cleanup!

> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> ---
>  include/net/inet_sock.h | 10 ++++------
>  net/ipv4/af_inet.c      |  4 ++--
>  net/ipv4/inet_diag.c    |  2 +-
>  net/ipv4/tcp.c          | 12 +++++++-----
>  net/ipv4/tcp_fastopen.c |  2 +-

The modifications in MPTCP code...

>  net/mptcp/protocol.c    | 10 ++++++----

... look good to me!

Reviewed-by: Matthieu Baerts <matthieu.baerts@...sares.net>

>  6 files changed, 21 insertions(+), 19 deletions(-)

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net