netdev - RE: [Intel-wired-lan] [PATCH net-next 2/3] virtchnl: fix fake 1-elem arrays in structures allocated as `nents + 1`

Open Source and information security mailing list archives

Message-ID: <BL0PR11MB3521D0C88253614A59E8E1548F15A@BL0PR11MB3521.namprd11.prod.outlook.com>
Date: Wed, 16 Aug 2023 12:49:35 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Kees Cook <keescook@...omium.org>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>
CC: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "Zaremba, Larysa"
	<larysa.zaremba@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Gustavo A. R. Silva" <gustavoars@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Eric Dumazet
	<edumazet@...gle.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "linux-hardening@...r.kernel.org"
	<linux-hardening@...r.kernel.org>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net-next 2/3] virtchnl: fix fake 1-elem
 arrays in structures allocated as `nents + 1`

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Kees Cook
> Sent: piątek, 4 sierpnia 2023 10:29
> To: Lobakin, Aleksander <aleksander.lobakin@...el.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; Zaremba,
> Larysa <larysa.zaremba@...el.com>; netdev@...r.kernel.org; Gustavo A. R.
> Silva <gustavoars@...nel.org>; linux-kernel@...r.kernel.org; Eric Dumazet
> <edumazet@...gle.com>; intel-wired-lan@...ts.osuosl.org; linux-
> hardening@...r.kernel.org; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>
> Subject: Re: [Intel-wired-lan] [PATCH net-next 2/3] virtchnl: fix fake 1-elem
> arrays in structures allocated as `nents + 1`
> 
> On Fri, Jul 28, 2023 at 05:52:06PM +0200, Alexander Lobakin wrote:
> > There are five virtchnl structures, which are allocated and checked in
> > the code as `nents + 1`, meaning that they always have memory for one
> > excessive element regardless of their actual number. This comes from
> > that their sizeof() includes space for 1 element and then they get
> > allocated via struct_size() or its open-coded equivalents, passing the
> > actual number of elements.
> > Expand virtchnl_struct_size() to handle such structures and replace
> > those 1-elem arrays with proper flex ones. Also fix several places
> > which open-code %IAVF_VIRTCHNL_VF_RESOURCE_SIZE. Finally, let the
> > virtchnl_ether_addr_list size be computed automatically when there's
> > no enough space for the whole list, otherwise we have to open-code
> > reverse struct_size() logics.
> >
> > Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> 
> I remain a fan of _Generic uses. :)
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> --
> Kees Cook
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@...osl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives