netdev - Re: [PATCH net-next] pds_core: remove redundant pci_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0d644ce7-88e2-4e51-8e04-5a39b80df5b8@amd.com>
Date: Wed, 16 Aug 2023 07:02:55 -0700
From: "Nelson, Shannon" <shannon.nelson@....com>
To: Yu Liao <liaoyu15@...wei.com>, netdev@...r.kernel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com
Cc: liwei391@...wei.com
Subject: Re: [PATCH net-next] pds_core: remove redundant pci_clear_master()

On 8/15/2023 6:38 PM, Yu Liao wrote:
> 
> pci_disable_device() involves disabling PCI bus-mastering. So remove
> redundant pci_clear_master().
> 
> Signed-off-by: Yu Liao <liaoyu15@...wei.com>
> ---
>   drivers/net/ethernet/amd/pds_core/main.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/main.c b/drivers/net/ethernet/amd/pds_core/main.c
> index 672757932246..ffe619cff413 100644
> --- a/drivers/net/ethernet/amd/pds_core/main.c
> +++ b/drivers/net/ethernet/amd/pds_core/main.c
> @@ -374,7 +374,6 @@ static int pdsc_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>          return 0;
> 
>   err_out_clear_master:
> -       pci_clear_master(pdev);

Sure, this seems to make sense.  However, if we're removing this call, 
then we should change the name of the goto label to something like 
err_out_disable_device.

sln

>          pci_disable_device(pdev);
>   err_out_free_ida:
>          ida_free(&pdsc_ida, pdsc->uid);
> @@ -439,7 +438,6 @@ static void pdsc_remove(struct pci_dev *pdev)
>                  pci_release_regions(pdev);
>          }
> 
> -       pci_clear_master(pdev);
>          pci_disable_device(pdev);
> 
>          ida_free(&pdsc_ida, pdsc->uid);
> --
> 2.25.1
> 
>