netdev - Re: [PATCH v2 3/5] dt-bindings: net: Add HPE GXP UMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 16 Aug 2023 16:26:09 +0000
From: "Hawkins, Nick" <nick.hawkins@....com>
To: Conor Dooley <conor@...nel.org>
CC: "christophe.jaillet@...adoo.fr" <christophe.jaillet@...adoo.fr>,
        "simon.horman@...igine.com" <simon.horman@...igine.com>,
        "andrew@...n.ch"
	<andrew@...n.ch>,
        "Verdun, Jean-Marie" <verdun@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com"
	<edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org"
	<robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org"
	<conor+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] dt-bindings: net: Add HPE GXP UMAC

Hi Conor,

Thanks for your feedback. I will provide an explanation below.

> > +description:
> > + HPE GXP 802.3 10/100/1000T Ethernet Unifed MAC controller.
> > + Device node of the controller has following properties.
> > +
> > +properties:
> > + compatible:
> > + const: hpe,gxp-umac
> > +


> > + use-ncsi:
> > + type: boolean
> > + description:
> > + Indicates if the device should use NCSI (Network Controlled
> > + Sideband Interface).


> How is one supposed to know if the device should use NCSI? If the
> property is present does that mean that the mac hardware supports
> it? Or is it determined by what board this mac is on?
> Or is this software configuration?

Hi Conor,

There are two MAC's available in the ASIC but only one can support
NCSI. Even though it supports NCSI does not mean the board has
been physically wired to support it. In terms of the device tree I would
expect the "use-ncsi" to be present in the dts board specific file.

There will be hardware configurations where both MAC0 and MAC1
will be using the SERDES connections. In that case there will be no
NCSI available.

Is a better description needed here to explain this?

Thanks,

-Nick Hawkins