lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230817121631.1878897-2-ruanjinjie@huawei.com> Date: Thu, 17 Aug 2023 20:16:28 +0800 From: Ruan Jinjie <ruanjinjie@...wei.com> To: <rafal@...ecki.pl>, <bcm-kernel-feedback-list@...adcom.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <opendmb@...il.com>, <florian.fainelli@...adcom.com>, <bryan.whitehead@...rochip.com>, <andrew@...n.ch>, <hkallweit1@...il.com>, <linux@...linux.org.uk>, <mdf@...nel.org>, <pgynther@...gle.com>, <Pavithra.Sathyanarayanan@...rochip.com>, <netdev@...r.kernel.org> CC: <ruanjinjie@...wei.com> Subject: [PATCH net-next v2 1/4] net: phy: fixed_phy: Fix return value check for fixed_phy_get_gpiod Since fixed_phy_get_gpiod() return NULL instead of ERR_PTR(), if it fails, the IS_ERR() can never return the error. So check NULL and return ERR_PTR(-EINVAL) if fails. Fixes: 71bd106d2567 ("net: fixed-phy: Add fixed_phy_register_with_gpiod() API") Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com> --- drivers/net/phy/fixed_phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c index aef739c20ac4..4e7406455b6e 100644 --- a/drivers/net/phy/fixed_phy.c +++ b/drivers/net/phy/fixed_phy.c @@ -239,8 +239,8 @@ static struct phy_device *__fixed_phy_register(unsigned int irq, /* Check if we have a GPIO associated with this fixed phy */ if (!gpiod) { gpiod = fixed_phy_get_gpiod(np); - if (IS_ERR(gpiod)) - return ERR_CAST(gpiod); + if (!gpiod) + return ERR_PTR(-EINVAL); } /* Get the next available PHY address, up to PHY_MAX_ADDR */ -- 2.34.1
Powered by blists - more mailing lists