netdev - Re: [RFC net-next v1 4/5] net: macsec: introduce mdo_insert_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 17 Aug 2023 14:19:27 +0300
From: "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, richardcochran@...il.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC net-next v1 4/5] net: macsec: introduce mdo_insert_tx_tag

On 17.08.2023 13:31, Sabrina Dubroca wrote:
> 
> One more question about the ordering of patches in this series: is
> macsec offload with your device functional without this and the final
> patch? Otherwise, I would put this patch first, and then the driver
> patches (either collapsed into a single patch, or preferably split out
> if there's a reasonable way to do it -- patch 3 is really huge and
> hard to review).
> 

MACsec offload works, but if the frames are sent back to back, then some 
of them will be dropped. I will reorder the patches and split the patch 3.

-- 
Radu P.