netdev - Re: [PATCH net-next 02/14] ice: refactor ice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 17 Aug 2023 14:30:10 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Jan Sokolowski <jan.sokolowski@...el.com>,
	Jacob Keller <jacob.e.keller@...el.com>,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>
Subject: Re: [PATCH net-next 02/14] ice: refactor ice_ddp to make functions
 static

On Wed, Aug 16, 2023 at 01:47:24PM -0700, Tony Nguyen wrote:
> From: Jan Sokolowski <jan.sokolowski@...el.com>
> 
> As following methods are not used outside of ice_ddp,
> they can be made static:
> ice_verify_pgk
> ice_pkg_val_buf
> ice_aq_download_pkg
> ice_aq_update_pkg
> ice_find_seg_in_pkg
> 
> Signed-off-by: Jan Sokolowski <jan.sokolowski@...el.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_ddp.c | 120 ++++++++++++-----------
>  drivers/net/ethernet/intel/ice/ice_ddp.h |  10 --
>  2 files changed, 61 insertions(+), 69 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>