lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230817113424.GM22185@unreal> Date: Thu, 17 Aug 2023 14:34:24 +0300 From: Leon Romanovsky <leon@...nel.org> To: Tony Nguyen <anthony.l.nguyen@...el.com> Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org, Jan Sokolowski <jan.sokolowski@...el.com>, Jacob Keller <jacob.e.keller@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com> Subject: Re: [PATCH net-next 04/14] ice: refactor ice_vf_lib to make functions static On Wed, Aug 16, 2023 at 01:47:26PM -0700, Tony Nguyen wrote: > From: Jan Sokolowski <jan.sokolowski@...el.com> > > As following methods are not used outside ice_vf_lib, > they can be made static: > ice_vf_rebuild_host_vlan_cfg > ice_vf_rebuild_host_tx_rate_cfg > ice_vf_set_host_trust_cfg > ice_vf_rebuild_host_mac_cfg > ice_vf_rebuild_aggregator_node_cfg > ice_vf_rebuild_host_cfg > ice_set_vf_state_qs_dis > ice_vf_set_initialized > > In order to achieve that, the order in which these > were defined was reorganized. > > Signed-off-by: Jan Sokolowski <jan.sokolowski@...el.com> > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com> > --- > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 468 +++++++++--------- > .../ethernet/intel/ice/ice_vf_lib_private.h | 2 - > 2 files changed, 234 insertions(+), 236 deletions(-) <...> > +/** > + * ice_vf_set_host_trust_cfg - set trust setting based on pre-reset value > + * @vf: VF to configure trust setting for > + */ > +static void ice_vf_set_host_trust_cfg(struct ice_vf *vf) > +{ > + if (vf->trusted) > + set_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps); > + else > + clear_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps); > +} assign_bit(ICE_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps, vf->trusted); Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists