lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <039324dd-96ae-41df-974a-6519ff8f8983@lunn.ch> Date: Thu, 17 Aug 2023 14:41:52 +0200 From: Andrew Lunn <andrew@...n.ch> To: Ruan Jinjie <ruanjinjie@...wei.com> Cc: rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, opendmb@...il.com, florian.fainelli@...adcom.com, bryan.whitehead@...rochip.com, hkallweit1@...il.com, linux@...linux.org.uk, mdf@...nel.org, pgynther@...gle.com, Pavithra.Sathyanarayanan@...rochip.com, netdev@...r.kernel.org Subject: Re: [PATCH net-next v2 2/4] net: bgmac: Fix return value check for fixed_phy_register() On Thu, Aug 17, 2023 at 08:16:29PM +0800, Ruan Jinjie wrote: > The fixed_phy_register() function returns error pointers and never > returns NULL. Update the checks accordingly. > > And it also returns -EPROBE_DEFER, -EINVAL and -EBUSY, etc, in addition to > -ENODEV, just return -ENODEV is not sensible, use > PTR_ERR to fix the issue. I would recommend changing not sensible to best practice, as i suggested in one of your other patches. Reviewed-by: Andrew Lunn <andrew@...n.ch> --- pw-bot: cr
Powered by blists - more mailing lists