netdev - Re: [PATCH net-next 2/3] amd-xgbe: Return proper error code for get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 17 Aug 2023 20:54:23 +0800
From: Ruan Jinjie <ruanjinjie@...wei.com>
To: Andrew Lunn <andrew@...n.ch>
CC: <Shyam-sundar.S-k@....com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <yisen.zhuang@...wei.com>,
	<salil.mehta@...wei.com>, <iyappan@...amperecomputing.com>,
	<keyur@...amperecomputing.com>, <quan@...amperecomputing.com>,
	<hkallweit1@...il.com>, <linux@...linux.org.uk>, <yankejian@...wei.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/3] amd-xgbe: Return proper error code for
 get_phy_device()



On 2023/8/17 20:28, Andrew Lunn wrote:
> On Thu, Aug 17, 2023 at 03:39:59PM +0800, Ruan Jinjie wrote:
>> get_phy_device() returns -EIO on bus access error and -ENOMEM
>> on kzalloc failure in addition to -ENODEV, just return -ENODEV is not
>> sensible, use PTR_ERR(phydev) to fix the issue.
> 
> Rather than say 'not sensible', it would be better to say 'Best
> practice is to return these error codes'.

Thank you! I'll watch the wording next time.

> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> 
>     Andrew
> 
> ---
> pw-bot: cr