lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8474ac51-9906-4b2a-6eb8-92fd19869bba@huawei.com> Date: Thu, 17 Aug 2023 21:01:14 +0800 From: Ruan Jinjie <ruanjinjie@...wei.com> To: Andrew Lunn <andrew@...n.ch> CC: <rafal@...ecki.pl>, <bcm-kernel-feedback-list@...adcom.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <opendmb@...il.com>, <florian.fainelli@...adcom.com>, <bryan.whitehead@...rochip.com>, <hkallweit1@...il.com>, <linux@...linux.org.uk>, <mdf@...nel.org>, <pgynther@...gle.com>, <Pavithra.Sathyanarayanan@...rochip.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v2 2/4] net: bgmac: Fix return value check for fixed_phy_register() On 2023/8/17 20:41, Andrew Lunn wrote: > On Thu, Aug 17, 2023 at 08:16:29PM +0800, Ruan Jinjie wrote: >> The fixed_phy_register() function returns error pointers and never >> returns NULL. Update the checks accordingly. >> >> And it also returns -EPROBE_DEFER, -EINVAL and -EBUSY, etc, in addition to >> -ENODEV, just return -ENODEV is not sensible, use >> PTR_ERR to fix the issue. > > I would recommend changing not sensible to best practice, as i > suggested in one of your other patches. Thank you again! I'll watch the wording next time. > > Reviewed-by: Andrew Lunn <andrew@...n.ch> > > --- > pw-bot: cr
Powered by blists - more mailing lists