lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <c908a4a7-7e76-4a0c-9003-435bda0653a7@roeck-us.net> Date: Thu, 17 Aug 2023 06:44:55 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Michael Chan <michael.chan@...adcom.com> Cc: Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>, davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, gospo@...adcom.com, Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org Subject: Re: [PATCH net-next 11/12] bnxt_en: Expose threshold temperatures through hwmon On Wed, Aug 16, 2023 at 11:28:07PM -0700, Michael Chan wrote: > On Wed, Aug 16, 2023 at 12:25 PM Guenter Roeck <linux@...ck-us.net> wrote: > > > > On Wed, Aug 16, 2023 at 09:42:17PM +0530, Kalesh Anakkur Purayil wrote: > > > [Kalesh]: Sorry, I don't quite get this part. I was looking at the kernel > > > hwmon code, but could not find any reference. > > > > > > > It would be non-standard attributes, so, correct, there is no reference. > > > > > Can we add new attributes "shutdown" and "shutdown_alarm" for tempX? For > > > example: > > > > > > #define HWMON_T_SHUTDOWN BIT(hwmon_temp_shutdown) > > > > > > > Not for a single driver. You can implement the sysfs attributes > > directly in the driver and pass an extra attribute group to the > > hwmon core when registering the hwmon device. > > Thanks for the review. I will drop these hwmon patches for now and > respin the others for v2. Kalesh will rework these hwmon patches. Alternatively you could keep the standard attributes and add the shutdown attributes later. Guenter
Powered by blists - more mailing lists