netdev - Re: [PATCH iwl-next 2/7] ice: Refactor finding advertised link speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <240678ed-221f-4893-a410-140c9f4f4674@lunn.ch>
Date: Thu, 17 Aug 2023 03:00:44 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Paul Greenwalt <paul.greenwalt@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	Pawel Chmielewski <pawel.chmielewski@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [PATCH iwl-next 2/7] ice: Refactor finding advertised link speed

On Wed, Aug 16, 2023 at 04:57:14PM -0700, Paul Greenwalt wrote:
> From: Pawel Chmielewski <pawel.chmielewski@...el.com>
> 
> Refactor ice_get_link_ksettings by using lightweight static link mode
> maps, populated at module init. This is an efficient solution introduced
> in commit 1d4e4ecccb11 ("qede: populate supported link modes maps on
> module init") for qede driver

Could this actually be partially shared with that driver? Some are
identical. Maybe a generic implementation in net/ethtool/ ?

	   Andrew