lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230817170932.GR22185@unreal> Date: Thu, 17 Aug 2023 20:09:32 +0300 From: Leon Romanovsky <leon@...nel.org> To: Tony Nguyen <anthony.l.nguyen@...el.com> Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org, Jacob Keller <jacob.e.keller@...el.com>, Przemek Kitszel <przemyslaw.kitszel@...el.com>, Arpana Arland <arpanax.arland@...el.com> Subject: Re: [PATCH net-next 08/14] ice: move E810T functions to before device agnostic ones On Wed, Aug 16, 2023 at 01:47:30PM -0700, Tony Nguyen wrote: > From: Jacob Keller <jacob.e.keller@...el.com> > > Commit 885fe6932a11 ("ice: Add support for SMA control multiplexer") > accidentally placed all of the E810T SMA control functions in the middle of > the device agnostic functions section of ice_ptp_hw.c > > This works fine, but makes it harder for readers to follow. The > ice_ptp_hw.c file is laid out such that each hardware family has the > specific functions in one block, with the access functions placed at the > end of the file. > > Move the E810T functions so that they are in a block just after the E810 > functions. Also move the ice_get_phy_tx_tstamp_ready_e810 which got added > at the end of the E810T block. > > This keeps the functions laid out in a logical order and avoids intermixing > the generic access functions with the device specific implementations. > > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com> > Tested-by: Arpana Arland <arpanax.arland@...el.com> (A Contingent worker at Intel) > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com> > --- > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 358 ++++++++++---------- > 1 file changed, 179 insertions(+), 179 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@...dia.com>
Powered by blists - more mailing lists