netdev - Re: [PATCH net-next 11/14] ice: drop two params from ice_aq_alloc_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230817171019.GU22185@unreal>
Date: Thu, 17 Aug 2023 20:10:19 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Tony Nguyen <anthony.l.nguyen@...el.com>
Cc: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	edumazet@...gle.com, netdev@...r.kernel.org,
	Przemek Kitszel <przemyslaw.kitszel@...el.com>,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 11/14] ice: drop two params from
 ice_aq_alloc_free_res()

On Wed, Aug 16, 2023 at 01:47:33PM -0700, Tony Nguyen wrote:
> From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> 
> Drop @num_entries and @cd params, latter of which was always NULL.
> 
> Number of entities to alloc is passed in internal buffer, the outer layer
> (that @num_entries was assigned to) meaning is closer to "the number of
> requests", which was =1 in all cases.
> ice_free_hw_res() was always called with 1 as its @num arg.
> 
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_common.c | 24 +++++++--------------
>  drivers/net/ethernet/intel/ice/ice_common.h |  7 +++---
>  drivers/net/ethernet/intel/ice/ice_lag.c    |  9 ++++----
>  drivers/net/ethernet/intel/ice/ice_switch.c | 16 ++++++--------
>  4 files changed, 22 insertions(+), 34 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>