netdev - Re: [PATCHv2 nf] netfilter: set default timeout to 3 secs for sctp shutdown send and recv state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ycoqoxkqgbhyudvhufzghix77yxymx6fdwccxltpo4vm7uvi6y@i4rak7os5des>
Date: Thu, 17 Aug 2023 15:04:54 -0300
From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To: Xin Long <lucien.xin@...il.com>
Cc: network dev <netdev@...r.kernel.org>, netfilter-devel@...r.kernel.org, 
	linux-sctp@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, 
	Pablo Neira Ayuso <pablo@...filter.org>, Jozsef Kadlecsik <kadlec@...filter.org>, 
	Florian Westphal <fw@...len.de>, Simon Horman <horms@...nel.org>, 
	Sriram Yagnaraman <sriram.yagnaraman@....tech>
Subject: Re: [PATCHv2 nf] netfilter: set default timeout to 3 secs for sctp
 shutdown send and recv state

On Tue, Aug 15, 2023 at 02:08:47PM -0400, Xin Long wrote:
...
> Note that the very short time value for SCTP_CONNTRACK_SHUTDOWN_SEND/RECV
> was probably used for a rare scenario where SHUTDOWN is sent on 1st path
> but SHUTDOWN_ACK is replied on 2nd path, then a new connection started
> immediately on 1st path. So this patch also moves from SHUTDOWN_SEND/RECV
> to CLOSE when receiving INIT in the ORIGINAL direction.

Yeah.

> 
> Fixes: 9fb9cbb1082d ("[NETFILTER]: Add nf_conntrack subsystem.")
> Reported-by: Paolo Valerio <pvalerio@...hat.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> Reviewed-by: Simon Horman <horms@...nel.org>

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>