netdev - Re: [PATCH net-next] pds_core: remove redundant pci_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <141862b6-e788-f16d-660b-e552b9fc4c6c@huawei.com>
Date: Thu, 17 Aug 2023 09:11:02 +0800
From: Yu Liao <liaoyu15@...wei.com>
To: "Nelson, Shannon" <shannon.nelson@....com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>
CC: <liwei391@...wei.com>
Subject: Re: [PATCH net-next] pds_core: remove redundant pci_clear_master()

On 2023/8/16 22:02, Nelson, Shannon wrote:
> On 8/15/2023 6:38 PM, Yu Liao wrote:
>>
>> pci_disable_device() involves disabling PCI bus-mastering. So remove
>> redundant pci_clear_master().
>>
>> Signed-off-by: Yu Liao <liaoyu15@...wei.com>
>> ---
>>   drivers/net/ethernet/amd/pds_core/main.c | 2 --
>>   1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/amd/pds_core/main.c
>> b/drivers/net/ethernet/amd/pds_core/main.c
>> index 672757932246..ffe619cff413 100644
>> --- a/drivers/net/ethernet/amd/pds_core/main.c
>> +++ b/drivers/net/ethernet/amd/pds_core/main.c
>> @@ -374,7 +374,6 @@ static int pdsc_probe(struct pci_dev *pdev, const struct
>> pci_device_id *ent)
>>          return 0;
>>
>>   err_out_clear_master:
>> -       pci_clear_master(pdev);
> 
> Sure, this seems to make sense.  However, if we're removing this call, then we
> should change the name of the goto label to something like
> err_out_disable_device.
> 
> sln

Right, I'll make changes in v2.

Best regards,
Yu
> 
>>          pci_disable_device(pdev);
>>   err_out_free_ida:
>>          ida_free(&pdsc_ida, pdsc->uid);
>> @@ -439,7 +438,6 @@ static void pdsc_remove(struct pci_dev *pdev)
>>                  pci_release_regions(pdev);
>>          }
>>
>> -       pci_clear_master(pdev);
>>          pci_disable_device(pdev);
>>
>>          ida_free(&pdsc_ida, pdsc->uid);
>> -- 
>> 2.25.1
>>
>>